use --time-cond when caching the formula api json #13584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is to fix #13583 by using
--time-cond "<date>"
instead of--header "If-Modified-Since: <date>"
when refreshing the cached Formula API. This prevents older versions ofcurl
(such as the Apple-suppliedcurl
in macOS Big Sur) from writing a zero-byte .json file. My change will also skip the mtime comparison and overwrite the cache file if the cache file is empty, in order to automatically fix this issue on affected systems.